Skip to content

Porting the TypeScript tests into solidity - #686

Merged
brickpop merged 36 commits into
mainfrom
f/foundry-test-suite-port
Jul 7, 2026
Merged

Porting the TypeScript tests into solidity#686
brickpop merged 36 commits into
mainfrom
f/foundry-test-suite-port

Conversation

@brickpop

@brickpop brickpop commented May 18, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Description

  • Porting the testing suite from TypeScript /HardHat) into native solidity (Foundry)
  • Consolidating OSx + the former osx-commons
  • Extending the testing coverage (unit, integration, smoke)

Also:

  • Syncing the docs (to pass the checks)
  • Syncing the ABI (to pass the checks)
  • Syncing just-foundry

@brickpop
brickpop force-pushed the f/foundry-test-suite-port branch from 3d9230b to 498c563 Compare May 18, 2026 16:37
@brickpop
brickpop force-pushed the f/foundry-test-suite-port branch from e3ef005 to 5e3c8f3 Compare May 26, 2026 17:37
@brickpop brickpop changed the title Starting to port the TypeScript tests into solidity Porting the TypeScript tests into solidity May 27, 2026
@brickpop
brickpop requested a review from xavikh May 27, 2026 22:39
@brickpop
brickpop force-pushed the f/foundry-test-suite-port branch 2 times, most recently from c867813 to 1fbca0e Compare June 2, 2026 12:13
brickpop added 24 commits June 10, 2026 11:28
@brickpop
Consistent behaviour with ANY_ADDR
681db77
@brickpop
Updated doc
74cf358
@brickpop
Starting to port the TypeScript tests into solidity
5ca5739
@brickpop
Permission and metadata tests
0cbaa14
@brickpop
Extension tests
8eb33e0
@brickpop
Test: src/common
9d45d30
@brickpop
Test: core utils
d600e4d
@brickpop
Test: framework utils
47610a5
@brickpop
Test: Registries
f349eb6
@brickpop
Test: Framework repo and factory
13003b8
@brickpop
Test: PermissionManager
eaa318c
@brickpop
Test: DAO tests
2c6a641
@brickpop
Test: PluginSetupProcessor chunks
af9f3fa
@brickpop
Test: DAO upgrade tests
1951013
@brickpop
Test: Removing the remaining outdated TS tests
fe5e7bb
@brickpop
Expanding DAO.t.sol tests
35fc057
@brickpop
Expanding the PermissionManager tests
bc8f15c
@brickpop
Extended PSP tests
7e67164
@brickpop
Broader PluginRepo testing
39bce79
@brickpop
PluginRepoFactory wider tests
fbfb57d
@brickpop
DaoFactory deeper testing
036d5df
@brickpop
PluginRepoRegistry deeper tests
0cfee00
@brickpop
DAO Registry and ENS Subdomain registrar wider testing
6ed80ff
@brickpop
InterfaceBasedRegistry: wider tests
51b6211
@brickpop
brickpop force-pushed the f/foundry-test-suite-port branch from 7450586 to 5e2bf9e Compare June 10, 2026 14:34
xavikh
xavikh reviewed Jun 15, 2026
View reviewed changes

@xavikh xavikh left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Solid port overall: builds clean, 896 tests pass. Detailed findings are inline. One thing up front that needs a call before merge:

Managing-DAO post-deployment checks were dropped with no replacement. The old deploy/managing-dao.ts (7 cases) verified the live managing DAO holds ROOT on itself and upgrade permission over the registries/registrars. A fork test against mainnet is the natural home (the pattern already exists in test/framework/member/fork/). Land it here or as a follow-up?

Comment thread test/framework/dao/DAORegistry.t.sol
Comment thread test/framework/plugin/setup/PSP.Update.t.sol Outdated
Comment thread test/framework/plugin/setup/PSP.UpdateScenarios.t.sol
Comment thread test/framework/plugin/setup/PSP.Installation.t.sol Outdated
Comment thread test/core/dao/DAO.t.sol Outdated
@brickpop

brickpop commented Jul 6, 2026

Copy link
Copy Markdown
Contributor Author

Managing-DAO post-deployment checks were dropped with no replacement. The old deploy/managing-dao.ts (7 cases) verified the live managing DAO holds ROOT on itself and upgrade permission over the registries/registrars. A fork test against mainnet is the natural home (the pattern already exists in test/framework/member/fork/). Land it here or as a follow-up?

These tests belong in the Protocol Factory, since it is what does the whole orchestration of Core + Plugins. The Management DAO cannot exist without the Multisig plugin setup being available I wouldn't introduce downstream dependencies here.

@brickpop
brickpop requested a review from xavikh July 6, 2026 15:38
@brickpop
brickpop merged commit 4100bcf into main Jul 7, 2026
6 checks passed
@brickpop
brickpop deleted the f/foundry-test-suite-port branch July 7, 2026 11:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@xavikh xavikh xavikh approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@brickpop @xavikh